[6.0.1] Match indexer properties correctly #26645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
reviewed
Nov 12, 2021
Co-authored-by: Shay Rojansky <[email protected]>
bricelam
approved these changes
Nov 15, 2021
AndriySvyryd
changed the title
ajcvickers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26590
Description
When an FK attribute is used with a property on a property bag entity type EF ends up creating a property with a uniquified name instead of using the specified one.
This is made worse in 6.0 because now EF scaffolds this type of configuration for existing databases.
Customer impact
User queries will throw exception since the new property doesn't match a column in the database
How found
Customer reported on 6.0
Regression
Yes, this worked in 5.0
Testing
Added test for this scenario.
Risk
Low, only affects property bag entities (
Dictionary<string, object>). Also added a quirk mode.