Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call sync connection close instead of async (7.0) #26942

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Conversation

roji
Copy link
Member

@roji roji commented Dec 8, 2021

Also add missing ConfigureAwait(false) and StringComparison.Ordinal, because of a configuration mismatch between FxCop and the built-in diagnostics analyzers.

Fixes #26790

@roji roji requested a review from a team December 8, 2021 13:09
Also add missing ConfigureAwait(false) and StringComparison.Ordinal,
because of a configuration mismatch between FxCop and the built-in
diagnostics analyzers.

Fixes dotnet#26790
@roji roji merged commit a778126 into dotnet:main Dec 16, 2021
@roji roji deleted the AsyncStuff branch December 16, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RelationalConnection.Close calls async function
2 participants