[6.0.2] Query: Assign proper type to CollectionResultExpression #27134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
changed the title
maumar
approved these changes
Jan 8, 2022
We copied type from subquery itself which is always Queryable type because of conversion we do. We need to convert it back to enumerable. Issue happens only when nested level because we use element type so for 1 level queryable is gone. But for nested level we get Queryable<T> as element type on outer which is not assignable from List<T> The conversion doesn't cause issue with user having Queryable in the result since that throws exception much earlier. Resolves #27105
smitpatel
force-pushed
the
smit/ListOfList
branch
from
f45af34
to
f2e1e9a
Compare
ajcvickers
changed the title
smitpatel
added a commit
that referenced
this pull request
Mar 17, 2022
This improves the fix made in #27134 In earlier PR we converted `IQueryable<T>` to `IEnumerable<T>` becaused we converted enumerable to queryable during preprocessing phase and types aligned in later phase since we create a list (which does implement `IEnumerable<T>`). Though this implementing behavior doesn't work when returning a single result of enumerable during async which wraps collection type inside Task. The better fix is to assign `List<T>` as type since we are eventually creating a list. In case of single result, the single result operator has generic type which will introduce convert node into it automatically which will match types for async tasks. Resolves #27600
smitpatel
added a commit
that referenced
this pull request
Mar 17, 2022
This improves the fix made in #27134 In earlier PR we converted `IQueryable<T>` to `IEnumerable<T>` becaused we converted enumerable to queryable during preprocessing phase and types aligned in later phase since we create a list (which does implement `IEnumerable<T>`). Though this implementing behavior doesn't work when returning a single result of enumerable during async which wraps collection type inside Task. The better fix is to assign `List<T>` as type since we are eventually creating a list. In case of single result, the single result operator has generic type which will introduce convert node into it automatically which will match types for async tasks. Resolves #27600
dougbu
pushed a commit
that referenced
this pull request
Apr 5, 2022
…27664) This improves the fix made in #27134 In earlier PR we converted `IQueryable<T>` to `IEnumerable<T>` becaused we converted enumerable to queryable during preprocessing phase and types aligned in later phase since we create a list (which does implement `IEnumerable<T>`). Though this implementing behavior doesn't work when returning a single result of enumerable during async which wraps collection type inside Task. The better fix is to assign `List<T>` as type since we are eventually creating a list. In case of single result, the single result operator has generic type which will introduce convert node into it automatically which will match types for async tasks. Resolves #27600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We copied type from subquery itself which is always Queryable type because of conversion we do. We need to convert it back to enumerable.
Issue happens only when nested level because we use element type so for 1 level queryable is gone. But for nested level we get Queryable as element type on outer which is not assignable from List
The conversion doesn't cause issue with user having Queryable in the result since that throws exception much earlier.
Resolves #27105
Description
When projecting enumerable of enumerable, we didn't assign correct type to expression tree when translating causing it to have incorrect type which later fails when generating compiled code.
Customer impact
Customers with enumerable of enumerable in projection will have query failing.
How found
Customer reported on 6.0.1
Regression
Yes, From 5.0
Testing
Added test for user scenario.
Risk
Very low risk. Also added quirk.