Remove nullability errors #27181
Merged
Remove nullability errors #27181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #26995
roji
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
LGTM (but see test failures).
Just to note that this could cause runtime failures.. When originally annotating, in cases of uncertainty I sometimes left runtime checks (i.e. coalescing operator) for members annotated as non-nullable - just in case. This removes these, which may cause NREs if the annotations are wrong. But it's a good time to do this in the beginning of the 7.0 cycle.
|
Errors don't seem to be related to nullable changes. Helix connects to external SqlServer causing all those tests to fail. The single test failure in windows look random as it passed for async but not for sync. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@smitpatel Build was broken: #27182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26995