Attribute for configuring composite primary keys #27571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
reviewed
Mar 8, 2022
There was a problem hiding this comment.
Here's a first round of comments, @AndriySvyryd will probably also want to take a look.
AndriySvyryd
reviewed
Mar 9, 2022
AndriySvyryd
reviewed
Mar 9, 2022
src/EFCore/Metadata/Conventions/Infrastructure/ProviderConventionSetBuilder.cs
Show resolved
Hide resolved
AndriySvyryd
reviewed
Mar 9, 2022
test/EFCore.Tests/Metadata/Conventions/PropertyAttributeConventionTest.cs
Show resolved
Hide resolved
ajcvickers
force-pushed
the
CompostableKey0302
branch
from
312042f
to
3cbf8db
Compare
|
New version up. |
AndriySvyryd
approved these changes
Mar 11, 2022
Fixes #11003 This PR introduces a new `[PrimaryKey]` which follows the same pattern as `[Index]` in that it is applied to the entity type class and takes an ordered list of property names. It takes precedence over any `[Key]` attributes on properties, since these may still be needed for OData or other technologies. `PrimaryKey` and `Keyless` cannot be used on the same type.
Co-authored-by: Shay Rojansky <[email protected]>
Co-authored-by: Shay Rojansky <[email protected]>
Co-authored-by: Shay Rojansky <[email protected]>
Co-authored-by: Shay Rojansky <[email protected]>
Co-authored-by: Shay Rojansky <[email protected]>
ajcvickers
force-pushed
the
CompostableKey0302
branch
from
3cbf8db
to
e153d22
Compare
|
Great feature! A much better way to define composite keys in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11003
This PR introduces a new
[PrimaryKey]which follows the same pattern as[Index]in that it is applied to the entity type class and takes an ordered list of property names. It takes precedence over any[Key]attributes on properties, since these may still be needed for OData or other technologies.PrimaryKeyandKeylesscannot be used on the same type.