Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SQL Server UTF8 strings #27634

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Support SQL Server UTF8 strings #27634

merged 4 commits into from
Mar 17, 2022

Conversation

roji
Copy link
Member

@roji roji commented Mar 13, 2022

Closes #25798

@roji roji requested a review from a team March 13, 2022 12:55
ajcvickers
ajcvickers approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved when test failures are fixed.

@roji
Copy link
Member Author

roji commented Mar 14, 2022

@ajcvickers did small product code fix, you may want to take another look.

@roji roji mentioned this pull request Mar 16, 2022
Open
@roji
Copy link
Member Author

roji commented Mar 16, 2022

Tests failing in the Windows build because of an older version of SQL Server (2019 is required), see #27650

@roji roji merged commit 587de30 into dotnet:main Mar 17, 2022
@roji roji deleted the SqlServerUTF8 branch March 17, 2022 13:42
@ajcvickers ajcvickers mentioned this pull request Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL Server UTF8 collations
2 participants
@roji @ajcvickers