[6.0.x] Return null constraint names for keys and FKs on entity types not mapped to a table. #27857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ped to a table. Fixes #27854
bricelam
approved these changes
Apr 22, 2022
ajcvickers
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When getting the FK name the code assumed that both entity types are mapped to tables, since it's the only way an FK constraint can be created in the database.
Customer impact
When creating a foreign key between an entity type mapped to a view and an entity type mapped to a table an exception is thrown. No known workaround other than not creating the FK.
How found
Customer reported on 6.0.
Regression
Yes, From 5.0.
Testing
Added tests for this scenario.
Risk
Low risk, avoids NRE.
Partial backport of 786cb40
Fixes #27854