Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Castle.Core from 4.4.1 to 5.0.0 #28035

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Bump Castle.Core from 4.4.1 to 5.0.0 #28035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0bfb2e
Bump Castle.Core from 4.4.1 to 5.0.0
dependabot[bot] May 16, 2022
2897911
Fixed tests broken by exception type changes.
ajcvickers Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore.Proxies/EFCore.Proxies.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Castle.Core" Version="4.4.1" />
<PackageReference Include="Castle.Core" Version="5.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions test/EFCore.Proxies.Tests/ProxyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,28 +206,28 @@ public void Proxy_services_must_be_available()
public void Throws_if_type_not_available_to_Castle()
{
using var context = new NeweyContextN4();
Assert.Throws<GeneratorException>(() => context.CreateProxy<McLarenMp421>());
Assert.Throws<ArgumentException>(() => context.CreateProxy<McLarenMp421>());
}

[ConditionalFact]
public void Throws_if_constructor_not_available_to_Castle()
{
using var context = new NeweyContextN5();
Assert.Throws<InvalidProxyConstructorArgumentsException>(() => context.CreateProxy<RedBullRb3>());
Assert.Throws<ArgumentException>(() => context.CreateProxy<RedBullRb3>());
}

[ConditionalFact]
public void CreateProxy_throws_if_constructor_args_do_not_match()
{
using var context = new NeweyContext();
Assert.Throws<InvalidProxyConstructorArgumentsException>(() => context.CreateProxy<March881>(77, 88));
Assert.Throws<ArgumentException>(() => context.CreateProxy<March881>(77, 88));
}

[ConditionalFact]
public void CreateProxy_throws_if_wrong_number_of_constructor_args()
{
using var context = new NeweyContext();
Assert.Throws<InvalidProxyConstructorArgumentsException>(() => context.CreateProxy<March881>(77, 88, 99));
Assert.Throws<ArgumentException>(() => context.CreateProxy<March881>(77, 88, 99));
}

[ConditionalFact]
Expand Down