-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CSharpHelper for Dictionary literals #28330
Conversation
7f4c173
to
f393b13
Compare
72618d5
to
e314e5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e314e5b
to
a956daf
Compare
All comments should have been addressed. TY |
Any reason this isn't getting merged? @bricelam |
Hello @bricelam! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
Apologies, while this PR appears ready to be merged, it looks like |
a956daf
to
6e1047b
Compare
Fixes #19274
[X] I've read the guidelines for contributing and seen the walkthrough
[X] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
[X] The code builds and tests pass locally (also verified by our automated build checks)
Commit messages follow this format:
Summary of the changes
- Detail 1
- Detail 2
[X] Tests for the changes have been added (for bug fixes / features)
[X] Code follows the same patterns and style as existing code in this repo