Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata work for json. #28540

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Metadata work for json. #28540

merged 1 commit into from
Aug 5, 2022

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Jul 29, 2022

Separated from main PR to make the review easier.

This PR includes:

  • builder methods,
  • conventions,
  • relational model,
  • model validation,
  • migrations,
  • update.

@maumar maumar force-pushed the json_metadata branch 2 times, most recently from bef2af8 to 881aae2 Compare July 29, 2022 07:20
roji
roji previously requested changes Jul 29, 2022
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a 1st round of comments from me. There are some questions we may want to discuss in design (e.g. distinction between columns and JSON properties, whether JSON properties should be represented as columns in the relational model).

Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrations changes LGTM

@maumar maumar force-pushed the json_metadata branch 5 times, most recently from 1162406 to 0edb97c Compare August 4, 2022 06:02
@AndriySvyryd
Copy link
Member

Add a JSON column to ModelSnapshotSqlServerTest

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 4, 2022

Add a test to MigrationsModelDifferTest for converting a string property of JSON type to a JSON-mapped entity type

@maumar maumar force-pushed the json_metadata branch 2 times, most recently from ae45d85 to e7d1bf4 Compare August 5, 2022 02:19
…ier.

This PR includes:

- builder methods,
- conventions,
- relational model,
- model validation,
- migrations,
- update
@maumar maumar merged commit 4018482 into main Aug 5, 2022
@maumar maumar deleted the json_metadata branch August 5, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants