Templates: Specify a groupIdentity for ef-templates #29118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Sep 18, 2022
lorcQc
approved these changes
Sep 19, 2022
|
It would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for VB templates. efcore/EFCore.VisualBasic#83? /cc @lorcQc
Description
EF7 allows templates to be used for scaffolding a DbContext and model from an existing database. We implemented C# support and provided extension points for other languages. This change is needed for the in-progress community implementation of VB support.
Customer impact
Allows the community to add VB support for scaffolding templates.
How found
Community work implementing VB support.
Regression
No. New feature.
Testing
The VB implementation will be the primary testing of this.
Risk
Low; no impact on C# support.