Async fix for "Generate values for PK properties that are also self-referencing FK properties" #29134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@roji If you are around, could I get a review of this? It has been approved by Tactics for RC2. |
roji
approved these changes
Sep 19, 2022
| @@ -59,9 +59,9 @@ public async Task Should_not_throw_if_specified_region_is_right() | |||
| using var context = new CustomerContext(options); | |||
| context.Database.EnsureCreated(); | |||
|
|
|||
| context.Add(customer); | |||
| await context.AddAsync(customer); | |||
There was a problem hiding this comment.
Does this remove the coverage from the sync path, i.e. should these tests be theories on async to test both paths?
There was a problem hiding this comment.
There is in general a huge amount of coverage for the sync path. That being said, it would be good to be more aware of testing both going forward.
ajcvickers
added a commit
that referenced
this pull request
Sep 19, 2022
…eferencing FK properties" (#29134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22585, #22573, #26448
Async code pat was not fixed in original PR. However, this was not exposed until additional bug fix for #26448 in EF7 RC2
Description
Using the async overload of
Addfails to generate a key value for TPT mappings where the primary keys of sub-tables are also foreign keys to the main table.Customer impact
Exception when using
AddAsyncin many TPT scenarios.How found
Found while writing samples for EF7.
Regression
Yes; worked in EF Core 6.0.
Testing
Added more use of
AddAsyncin tests.Risk
Low; async code path was missing a check that existed in the sync code path.