[release/6.0] Query: Use type mapping from IDbFunction while translating (#27995) #29216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
changed the title
roji
approved these changes
Oct 10, 2022
|
@rbhanda what is this PR blocked on❔ release/6.0 is now open in this PR since branding changes are in for 6.0.12. |
|
@dougbu It's not blocked anymore. We just didn't want it going in for 6.0.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27954
Resolves #27524
Resolves #29204
Description
Custom mappings to database functions are not using the correct type mappings for parameters of the functions. This makes it impossible to map these database functions. These issues have been fixed and tested in EF7, and this change brings the fixes back to LTS EF Core 6.0, since there are no workarounds.
Customer impact
Impossible to map database functions where the type mapping for parameters is important. There is no known workaround.
How found
Multiple customer reports.
Regression
No.
Testing
These issues have been fixed and tested in EF7.
Risk
Low; correct type mappings now used.