Validate that the main fragment of optional dependents that use table sharing have at least one required non-shared property #29277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sharing have at least one required non-shared property Fixes #29079
ajcvickers
approved these changes
Oct 6, 2022
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29079
Customer Impact
When querying optional dependents using table sharing normally EF determines whether they exist by checking all required non-shared columns for NULLs. However, if they are also using entity splitting EF would need to check all table fragments which would be suboptimal from a perf standpoint. Currently EF will only check the properties on the main fragment and the added validation will throw for models that could produce invalid results.
Regression?
No. Entity splitting is a new feature.
Risk
Low. This change is constrained to model validation.
Verification
Added a test for the affected scenario.