Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToString() on string columns added #29349

Merged
merged 1 commit into from
Nov 9, 2022
Merged

ToString() on string columns added #29349

merged 1 commit into from
Nov 9, 2022

Conversation

bikbov
Copy link
Contributor

@bikbov bikbov commented Oct 13, 2022

  • Adding ToString() on string columns
  • Adding tests for the changes

Fixes #20839

@ajcvickers ajcvickers merged commit d4aa1ea into dotnet:main Nov 9, 2022
@ajcvickers
Copy link
Member

Thanks for the contribution!

roji added a commit to roji/efcore that referenced this pull request Nov 9, 2022
roji added a commit to roji/efcore that referenced this pull request Nov 9, 2022
@bikbov
Copy link
Contributor Author

bikbov commented Nov 10, 2022

Glad I could help

@bikbov bikbov deleted the issue-20839 branch November 10, 2022 21:47
@bikbov bikbov restored the issue-20839 branch November 10, 2022 21:47
@bikbov bikbov deleted the issue-20839 branch November 10, 2022 21:50
@bikbov bikbov restored the issue-20839 branch November 11, 2022 01:25
@@ -67,6 +67,11 @@ public SqlServerObjectToStringTranslator(ISqlExpressionFactory sqlExpressionFact
return null;
}

if(instance.TypeMapping is not null && instance.TypeMapping.ClrType == typeof(string))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after if

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this in #29522

ghost pushed a commit that referenced this pull request Nov 15, 2022
@bikbov bikbov deleted the issue-20839 branch November 29, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate ToString() on a string column
4 participants