Fix to #28881 - Consider removing unnecessary CASTs around JSON_VALUE

[maumar]

We can remove cast for string scalars, other types maybe cause conversion issues in the generated sql.

Fixes #28881

[ghost]

Hello @maumar!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this

From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

[roji]

Great to see this.

IMHO we should consider patching this... it certainly seems low-risk, and this issue prevents indexing from being used on strings properties in JSON, as we've seen in the recent conversations on Twitter.

[maumar]

@ajcvickers to make the call if we should patch. Risk does seem low.

[roji]

@maumar let me know when you want a review on this.

[maumar]

@roji ready for the review

[roji]

LGTM @maumar, but one question - this removes the cast also for cases where we have a length (e.g. nvarchar(10)).

I think it's a bit dubious to have this kind of type mapping on a JSON property, since it's not supported by the database in any way: JSON properties don't have types like columns, and the database never enforces a max length on them, etc.

But regardless... We can leave the cast, in order to have the DB truncate the string (in case someone inserted a longer value into the database). I don't think it's important to do that, mostly raising it as a question.