Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!fixup! Correct CodeQL3000 setup #29458

Merged
merged 1 commit into from
Oct 31, 2022
Merged

!fixup! Correct CodeQL3000 setup #29458

merged 1 commit into from
Oct 31, 2022

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Oct 31, 2022

  • add tag only when CodeQL3000 tasks did useful work
    • ignore no-op task executions
  • correct tsaoptions.json location

@dougbu
!fixup! Correct CodeQL3000 setup
8d1f17a 
- add tag only when CodeQL3000 tasks did useful work
  - ignore no-op task executions
- correct tsaoptions.json location
@dougbu dougbu requested review from garath and a team October 31, 2022 04:11
@dougbu
Copy link
Member Author

dougbu commented Oct 31, 2022

Corrections already applied in PRs for servicing branches in this repo. Working my way back through repos I thought I finished with…

dougbu
dougbu commented Oct 31, 2022
View reviewed changes
azure-pipelines.yml
# CodeQL3000 needs this plumbed along as a variable to enable TSA.
- Codeql.TSAEnabled: ${{ eq(variables['Build.Reason'], 'Schedule') }}
# Default expects tsaoptions.json under SourceRoot.
- Codeql.TSAOptionsPath: '$(Build.SourcesDirectory)/.config/tsaoptions.json'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wtgodbe this may be important in some of your PRs as well

@dougbu dougbu merged commit 479389a into dotnet:main Oct 31, 2022
@dougbu dougbu deleted the dougbu/CodeQL3000/main.fixup branch October 31, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@garath garath garath approved these changes

Assignees
No one assigned
Labels
area-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @garath @wtgodbe