Fix value generation with converter between different numeric types #29601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #29406 The value generator selection was returning a generator for the converted type, when a value for the non-converted type should have been used.
ajcvickers
force-pushed
the
NotMyType1115
branch
from
027046c
to
59c35e1
Compare
| generator = TryCreate(); | ||
| if (generator != null) | ||
| { | ||
| return generator; |
There was a problem hiding this comment.
When does this path get used? Wouldn't it result in the same exception?
There was a problem hiding this comment.
No, because this path is used when the generator is being created for the converted value--for example, when an int is wrapped in a class. For that path, the generator is used WithConverter.
There was a problem hiding this comment.
Smells like bad coupling. I think there could be more issues hiding here. This makes #25926 more useful.
There was a problem hiding this comment.
It is. I started down the rabbit hole of changing the signature here, but it was quite breaking, and so went for this fix for now. It may be worth revisiting.
AndriySvyryd
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29406
The value generator selection was returning a generator for the converted type, when a value for the non-converted type should have been used.