Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow shared columns with nullable value converters #29746

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Allow shared columns with nullable value converters #29746

merged 1 commit into from
Dec 5, 2022

Conversation

AndriySvyryd
Copy link
Member

Make IColumn.ProviderClrType always non-nullable for value types

Fixes #29531

@AndriySvyryd AndriySvyryd requested a review from a team December 3, 2022 05:45
@AndriySvyryd AndriySvyryd mentioned this pull request Dec 5, 2022
Merged
@AndriySvyryd
Allow shared columns with nullable value converters
ba6ed8f 
Make IColumn.ProviderClrType always non-nullable for value types

Fixes #29531
@AndriySvyryd AndriySvyryd merged commit 61be828 into main Dec 5, 2022
@AndriySvyryd AndriySvyryd deleted the Issue29531 branch December 5, 2022 22:38
@ajcvickers ajcvickers mentioned this pull request Jan 5, 2023
Closed
ajcvickers added a commit that referenced this pull request Feb 6, 2023
@ajcvickers
[release/7.0] Use correct provider type for nullable value type with …
566826b 
…converter

Port of #29746
Fixes #29985
@ajcvickers ajcvickers mentioned this pull request Feb 6, 2023
Merged
ajcvickers added a commit that referenced this pull request Feb 14, 2023
@ajcvickers
[release/7.0] Use correct provider type for nullable value type with …
f4e549e 
…converter

Port of #29746
Fixes #29985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AndriySvyryd @ajcvickers