Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NativeAOT support for Change Tracking #30256

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Add NativeAOT support for Change Tracking #30256

merged 1 commit into from
Jul 13, 2023

Conversation

AndriySvyryd
Copy link
Member

This is a proof of concept, it's still missing the compiled model generation code, this depends on #29949

Also, while there are workarounds, I ran into the following issues: dotnet/runtime#81741, dotnet/runtime#81803, dotnet/runtime#80037, dotnet/sdk#30094

Making SaveChanges compatible with NativeAOT depends on #24896

Part of #29761

@AndriySvyryd AndriySvyryd requested a review from a team February 11, 2023 05:06
@ajcvickers
Copy link
Member

@AndriySvyryd Can you go over this in the design meeting today?

ajcvickers
ajcvickers approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as bad as I thought it was going to be. Nice.

@roji
Copy link
Member

roji commented Apr 3, 2023 •
edited
Loading

@AndriySvyryd is it worth you going over this in a design meeting (assuming I haven't missed one where it was already done)?

@AndriySvyryd AndriySvyryd marked this pull request as ready for review July 13, 2023 07:01
@AndriySvyryd AndriySvyryd requested a review from a team as a code owner July 13, 2023 20:11
@AndriySvyryd AndriySvyryd merged commit c50e2f6 into main Jul 13, 2023
7 checks passed
@AndriySvyryd AndriySvyryd deleted the NativeAOT branch July 13, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriySvyryd @ajcvickers @roji