SQLite: Translate Math.Sign #30925
SQLite: Translate Math.Sign #30925
Conversation
| @@ -78,7 +84,7 @@ public SqliteMathTranslator(ISqlExpressionFactory sqlExpressionFactory) | |||
| { | |||
| RelationalTypeMapping? typeMapping; | |||
| List<SqlExpression>? newArguments = null; | |||
| if (sqlFunctionName == "max" || sqlFunctionName == "max") | |||
| if (sqlFunctionName == "max" || sqlFunctionName == "min") | |||
There was a problem hiding this comment.
Oops - so we weren't inferring correctly for min previous...
| if (sqlFunctionName == "max" || sqlFunctionName == "min") | |
| if (sqlFunctionName is "min" or "max") |
There was a problem hiding this comment.
lol, I reject your new age sorcery. (I'm going to change it in the big Math PR anyway.)
Oops - so we weren't inferring correctly for min previous...
Yeah, but we'd still infer it from the first argument which is most likely your column anyway. Also type-mappings are a lot less important on SQLite since you can just ask the ADO.NET provider for whatever type you want. So yeah, there was probably a corner-case involving value converters somewhere that this fixes.
There was a problem hiding this comment.
lol, I reject your new age sorcery. (I'm going to change it in the big Math PR anyway.)
Oh that's nothing, take a look at what @maumar has to put up with 🤣
Part of #18843