Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add complex type mappings to the default relational mappings #32901

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

ajcvickers
Copy link
Member

Port of #32867
Fixes #32699

Description

Raw SQL queries with FromSql use different default type mappings than other queries. These mappings were not correctly updated for complex types, a new feature in 8.0.

Customer impact

FromSql queries for entity types that contain complex types will throw.

How found

Customer reported on 8.

Regression

No, complex types is a new feature in 8.

Testing

Tests added.

Risk

Low. Quirked.

* Add complex type mappings to the default relational mappings

Replaces #32816
Fixes #32699

As discussed, leaving FromSql to use the default mappings, but add complex types to the default mappings.

* Add note to SelectExpression
@ajcvickers ajcvickers requested a review from a team January 23, 2024 15:59
@ajcvickers ajcvickers added this to the 8.0.x milestone Jan 23, 2024
@AndriySvyryd AndriySvyryd changed the title Add complex type mappings to the default relational mappings [release/8.0] Add complex type mappings to the default relational mappings Jan 23, 2024
@AndriySvyryd
Copy link
Member

Note that the branch is currently closed.

@AndriySvyryd AndriySvyryd modified the milestones: 8.0.x, 8.0.3 Jan 24, 2024
@maumar maumar merged commit c5d8f3c into release/8.0 Feb 7, 2024
7 checks passed
@maumar maumar deleted the 240123_FearOfASimplePlanet branch February 7, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants