Leverage KeyedServices feature in HttpClient logging #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xakep139
commented
Aug 8, 2023
test/Libraries/Microsoft.Extensions.Http.Telemetry.Tests/Logging/HttpClientLoggerTest.cs
Outdated
Show resolved
Hide resolved
…ng/HttpClientLoggerTest.cs
xakep139
commented
Aug 8, 2023
src/Libraries/Microsoft.Extensions.Http.Telemetry/Logging/Internal/HttpClientLogger.cs
Outdated
Show resolved
Hide resolved
geeknoid
approved these changes
Aug 8, 2023
RussKie
reviewed
Aug 10, 2023
src/Libraries/Microsoft.Extensions.Http.Telemetry/Logging/Internal/ServiceProviderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.Http.Telemetry/Logging/Internal/HttpClientLogger.cs
Outdated
Show resolved
Hide resolved
RussKie
added
the
waiting-author-feedback 📭
ghost
removed
the
waiting-author-feedback 📭
RussKie
approved these changes
Aug 14, 2023
src/Libraries/Microsoft.Extensions.Http.Telemetry/Logging/Internal/OptionsExtensions.cs
Outdated
Show resolved
Hide resolved
xakep139
added a commit
that referenced
this pull request
Aug 21, 2023
* use new .NET 8 runtime APIs in HttpClient logging * Leverage KeyedServices feature in HttpClient logging (#4253) Co-authored-by: Nikita Balabaev <[email protected]>
xakep139
added a commit
that referenced
this pull request
Aug 21, 2023
* use new .NET 8 runtime APIs in HttpClient logging * Leverage KeyedServices feature in HttpClient logging (#4253) Co-authored-by: Nikita Balabaev <[email protected]>
geeknoid
pushed a commit
that referenced
this pull request
Aug 21, 2023
* use new .NET 8 runtime APIs in HttpClient logging * Leverage KeyedServices feature in HttpClient logging (#4253) Co-authored-by: Nikita Balabaev <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Microsoft Reviewers: Open in CodeFlow