Drop FailureResultContext #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
xakep139
reviewed
Oct 23, 2023
...Libraries/Microsoft.Extensions.Http.Resilience/Resilience/Internal/HttpResilienceTagNames.cs
Outdated
Show resolved
Hide resolved
|
cc @joperezr |
geeknoid
approved these changes
Oct 23, 2023
…ilureresultcontext
martintmk
commented
Oct 24, 2023
| @@ -20,7 +19,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <Stage>normal</Stage> | |||
| <MinCodeCoverage>98</MinCodeCoverage> | |||
| <MinCodeCoverage>97</MinCodeCoverage> | |||
There was a problem hiding this comment.
Should be at 100, but code coverage is reporting lower number :/
There was a problem hiding this comment.
It's been reported as
Because of this:
There was a problem hiding this comment.
...though the validation script reports it as 97.38%...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When going over #4482 I realized that
FailureResultContextis something that is not required with Polly v8.The idea behind
FailureResultContextwas to allow to customize the metering dimensions based on the result type. However, Polly v8 supports telemetry enrichment natively and this API feels unnecessary now.Instead of using
FailureResultContext, the consumer of Polly can just register their ownMeteringEnricherand use it to extract the result and add whatever dimensions they want.Microsoft Reviewers: Open in CodeFlow