Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the 'locker' GitHub action for locking closed/stale issues/PRs #4774

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jeffhandley
Copy link
Member

@jeffhandley jeffhandley commented Dec 1, 2023

This migrates away from the FabricBot implementation of a scheduled search over closed issues and adopts the Locker GitHub action authored by the VS Code team.

The updated fabricbot.json was generated via dotnet/fabricbot-config#83. The workflow file was implemented and tested at https://github.com/dotnet/fabricbot-config/blob/main/.github/workflows/locker.yml.

Since this workflow uses the actions/checkout action, we need to ensure the following GitHub Actions settings are enabled:

  1. Allow enterprise, and select non-enterprise, actions and reusable workflows
  2. Allow actions created by GitHub
Microsoft Reviewers: Open in CodeFlow

runs-on: ubuntu-latest
steps:
- name: Checkout Actions
uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use checkout@v3:

uses: actions/checkout@v3

Can we use the same? Or we specifically need v4?

We can probably update the others to v4, if required...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know if v4 was required here. It's a straightforward git clone, so I suspect it would work. Since this PR has already been merged, I'll leave it to you to update this or other actions as you see fit though, @RussKie.

@RussKie RussKie merged commit fb4b1b2 into main Dec 1, 2023
2 checks passed
@RussKie RussKie deleted the jeffhandley/locker-action branch December 1, 2023 05:46
@ghost ghost added this to the 8.1 milestone Dec 1, 2023
@RussKie
Copy link
Member

RussKie commented Dec 1, 2023

Thank you

@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants