Support content headers in HttpClient logging #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add benchmark
…hub.com/dotnet/extensions into xakep139/httpclient-log-content-headers
…hub.com/dotnet/extensions into xakep139/httpclient-log-content-headers
xakep139
commented
Dec 29, 2023
.../Microsoft.Extensions.Http.Diagnostics.PerformanceTests/Benchmarks/HeadersReaderBenchmark.cs
Show resolved
Hide resolved
geeknoid
reviewed
Dec 29, 2023
src/Libraries/Microsoft.Extensions.Http.Diagnostics/Logging/Internal/HttpHeadersReader.cs
Outdated
Show resolved
Hide resolved
geeknoid
approved these changes
Jan 3, 2024
|
@RussKie can you please check what's wrong with the code coverage build step? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xakep139
commented
Jan 4, 2024
| @@ -39,3 +39,4 @@ steps: | |||
| repositoryName: '$(Build.Repository.Name)' | |||
| id: $(System.PullRequest.PullRequestNumber) | |||
| displayName: Report coverage to GitHub | |||
| continueOnError: 'true' # Temporary setting to avoid failing the build if the GitHub comment fails | |||
There was a problem hiding this comment.
@RussKie I added this suppression to unblock the build. Please so the proper fix when you're back from vacation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4769
Microsoft Reviewers: Open in CodeFlow