Detect connection timeouts in Hedging #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xakep139
changed the title
xakep139
commented
May 2, 2024
| @@ -4,11 +4,6 @@ | |||
| <Description>Unit tests for Microsoft.Extensions.Http.Resilience.</Description> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition=" '$(TargetFramework)' == 'net462' "> | |||
There was a problem hiding this comment.
I didn't face any issues locally nor did observe any during the CI build. I think we can safely close #4531 with that change
xakep139
commented
May 2, 2024
...raries/Microsoft.Extensions.Http.Resilience/Hedging/HttpClientHedgingResiliencePredicates.cs
Outdated
Show resolved
Hide resolved
geeknoid
approved these changes
May 2, 2024
martintmk
reviewed
May 3, 2024
...raries/Microsoft.Extensions.Http.Resilience/Hedging/HttpClientHedgingResiliencePredicates.cs
Show resolved
Hide resolved
martintmk
reviewed
May 6, 2024
...raries/Microsoft.Extensions.Http.Resilience/Hedging/HttpClientHedgingResiliencePredicates.cs
Outdated
Show resolved
Hide resolved
martintmk
approved these changes
May 7, 2024
iliar-turdushev
approved these changes
May 9, 2024
|
/backport to release/8.5 |
|
Started backporting to release/8.5: https://github.com/dotnet/extensions/actions/runs/9023344427 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4654
Microsoft Reviewers: Open in CodeFlow