FakeTimeProvider usage update #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
approved these changes
May 22, 2024
RussKie
reviewed
May 23, 2024
Comment on lines
+389
to
+392
| var retries = 42; | ||
| var tries = 0; | ||
| var taskDelay = 0.5; | ||
| var delay = 1; |
There was a problem hiding this comment.
Please don't use var for intrinsic types.
| } | ||
|
|
||
| // Act | ||
| var result = simulatedPollyRetry(); |
There was a problem hiding this comment.
Please don't use var unless the type is obvious.
https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/coding-style.md #10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4912
Adds additional test and information regarding usage of FakeTimeProvider
Microsoft Reviewers: Open in CodeFlow