Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsaconfig #5285

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Add tsaconfig #5285

merged 3 commits into from
Jul 20, 2024

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Jul 11, 2024

  • Copy add TSA config aspire#4860
  • Move existing empty credscan suppressions file to the location used by other repos to be consistent. (Was it being picked up before, without a tsa config file?)
Microsoft Reviewers: Open in CodeFlow

@danmoseley danmoseley added the * NO MERGE * Do not merge this PR as long as this label is present. label Jul 11, 2024
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting this done @danmoseley!

Regarding the rename of CredScanSuppressions, I'm assuming this is following 1ES guidelines of where they should be located at?

@mmitche
Copy link
Member

mmitche commented Jul 17, 2024

Can you enable policheck in the 1ES templates with this PR?

@danmoseley
Copy link
Member Author

Added. Jose after this goes in you'll want to check that all the right tools and things run..

@joperezr
Copy link
Member

Added. Jose after this goes in you'll want to check that all the right tools and things run..

Yeah, one thing we can do is before merging, we can trigger an internal build from your branch and then do a diff to make sure all the right steps are still running.

@danmoseley
Copy link
Member Author

I'll let you do that since you are probably a better person to interpret it..

@danmoseley danmoseley added area-infrastructure and removed * NO MERGE * Do not merge this PR as long as this label is present. labels Jul 18, 2024
@danmoseley danmoseley merged commit ff43443 into dotnet:main Jul 20, 2024
6 checks passed
@danmoseley danmoseley deleted the tsaconfig branch July 20, 2024 06:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants