Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable back potentially flaky test #5308

Conversation

evgenyfedorov2
Copy link
Contributor

@evgenyfedorov2 evgenyfedorov2 commented Jul 25, 2024

Fixes #3997

Just run the test 1000 times with local Visual Studio and WSL and never seen a failure.

Microsoft Reviewers: Open in CodeFlow

@dotnet-bot
Copy link
Contributor

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.ResourceMonitoring 98 99

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=755174&view=codecoverage-tab

@RussKie
Copy link
Member

RussKie commented Jul 26, 2024

🎉 Good job! The coverage increased 🎉 Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.ResourceMonitoring 98 99
Full code coverage report: dev.azure.com/dnceng-public/public/_build/results?buildId=755174&view=codecoverage-tab

Good stuff! Could you please bump the coverage?
Thank you

@evgenyfedorov2 evgenyfedorov2 merged commit d1e3541 into dotnet:main Jul 26, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Microsoft.Extensions.Diagnostics.ResourceMonitoring.Linux.Test
3 participants