Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable S3236 in fake time provider. #5315

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Jul 29, 2024

Submitting to unblock this dependency update PR:

#5313

Microsoft Reviewers: Open in CodeFlow

@dotnet-bot
Copy link
Contributor

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.ResourceMonitoring 98 99

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=758394&view=codecoverage-tab

@RussKie RussKie merged commit e18a59d into main Jul 29, 2024
6 checks passed
@RussKie RussKie deleted the mitchdenny/disable-S3236 branch July 29, 2024 03:01
@RussKie
Copy link
Member

RussKie commented Jul 29, 2024

Thank you @mitchdenny. Generally, such changes should be pushed straight into the blocked PRs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants