Add metrics with correct names for Resource Monitoring #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5d54584.
evgenyfedorov2
commented
Aug 6, 2024
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Calculator.cs
Show resolved
Hide resolved
evgenyfedorov2
commented
Aug 6, 2024
...braries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/WindowsNetworkMetrics.cs
Show resolved
Hide resolved
RussKie
reviewed
Aug 8, 2024
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceUtilizationInstruments.cs
Show resolved
Hide resolved
RussKie
reviewed
Aug 12, 2024
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs
Outdated
Show resolved
Hide resolved
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceUtilizationInstruments.cs
Outdated
Show resolved
Hide resolved
...ibraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Interop/IProcessInfo.cs
Outdated
Show resolved
Hide resolved
...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/ResourceUtilizationInstruments.cs
Outdated
Show resolved
Hide resolved
|
@joperezr - could you please take a look and give your approval when you have time? |
RussKie
approved these changes
Aug 12, 2024
joperezr
added a commit
to joperezr/extensions
that referenced
this pull request
Aug 15, 2024
…ng (dotnet#5341) Add metrics with correct names for Resource Monitoring (dotnet#5341) Fixes dotnet#5113 Previous art: dotnet#5309 Add new metrics with correct names. Old metrics will continue to be enabled by default. ### Existing metric setup **Windows Snapshot provider class** `process.cpu.utilization` `dotnet.process.memory.virtual.utilization` **Windows Container Snapshot provider class** `process.cpu.utilization` `dotnet.process.memory.virtual.utilization` **Linix Utilization Provider class** `process.cpu.utilization` `dotnet.process.memory.virtual.utilization` ### New metric setup **Windows Snapshot provider class** `process.cpu.utilization` - no changes `dotnet.process.memory.virtual.utilization` - no changes **Windows Container Snapshot provider class** `process.cpu.utilization` - no changes `dotnet.process.memory.virtual.utilization` - calculates memory for the dotnet process only (instead of all processes) `container.cpu.limit.utilization` - new metric, same value as `process.cpu.utilization` `container.memory.limit.utilization` - new metric, calculates memory for all processes in the container **Linux Utilization Provider class** `process.cpu.utilization` - fixed incorrect scale calculation, instead of `host CPUs / CPU limit / CPU request`, it is now `host CPUs / CPU request` `dotnet.process.memory.virtual.utilization` - no changes `container.cpu.limit.utilization` - new metric, value is relative to CPU resource limit (aka maximum CPU units) `container.memory.limit.utilization` - new metric, calculates memory for all processes in the container `container.cpu.request.utilization` - new metric, same value as `process.cpu.utilization` ---- #### AI description (iteration 1) #### PR Classification New feature: Added metrics with correct names for resource monitoring. #### PR Summary This pull request introduces new metrics for resource monitoring with correct naming conventions and updates the related tests and implementation. - `LinuxUtilizationProvider.cs`: Added new metrics for container CPU and memory utilization, and updated existing metrics. - `AcceptanceTest.cs`: Added new tests for verifying the new metrics and updated existing tests for better coverage. - `ResourceUtilizationInstruments.cs`: Defined new constants for the new metrics. - Removed `WindowsCounters.cs` as it is no longer needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5113
Rather than renaming, I added new metrics with correct names. Old metrics will continue to be enabled by default.
Existing metric setup
Windows Snapshot provider class
process.cpu.utilizationdotnet.process.memory.virtual.utilizationWindows Container Snapshot provider class
process.cpu.utilizationdotnet.process.memory.virtual.utilizationLinix Utilization Provider class
process.cpu.utilizationdotnet.process.memory.virtual.utilizationNew metric setup
Windows Snapshot provider class
process.cpu.utilization- no changesdotnet.process.memory.virtual.utilization- no changesWindows Container Snapshot provider class
process.cpu.utilization- no changesdotnet.process.memory.virtual.utilization- calculates memory for the dotnet process only (instead of all processes)container.cpu.limit.utilization- new metric, same value asprocess.cpu.utilizationcontainer.memory.limit.utilization- new metric, calculates memory for all processes in the containerLinux Utilization Provider class
process.cpu.utilization- fixed incorrect scale calculation, instead ofhost CPUs / CPU limit / CPU request, it is nowhost CPUs / CPU requestdotnet.process.memory.virtual.utilization- no changescontainer.cpu.limit.utilization- new metric, value is relative to CPU resource limit (aka maximum CPU units)container.memory.limit.utilization- new metric, calculates memory for all processes in the containercontainer.cpu.request.utilization- new metric, same value asprocess.cpu.utilizationPrevious art: #5309
Microsoft Reviewers: Open in CodeFlow