Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceUtilizationHealthCheck - Report both CPU and Memory issues #5407

Merged
merged 3 commits into from
Sep 9, 2024
Merged

ResourceUtilizationHealthCheck - Report both CPU and Memory issues #5407

merged 3 commits into from
Sep 9, 2024

Conversation

willibrandon
Copy link
Contributor

@willibrandon willibrandon commented Sep 7, 2024 •
edited by dotnet-policy-service bot
Loading

Fixes #4677

Proposed changes

  • Report both CPU and Memory issues when checking health based on resource utilization.

Customer Impact

  • Fixes an issue where only CPU or Memory issues are reported during a resource utilization health check, but not both.
  • This change also includes the additional key-value pairs describing the health of each component in the health check result.

Test methodology

  • Updated ResourceHealthCheckTests to accommodate for this change.
  • Ran all tests.
Microsoft Reviewers: Open in CodeFlow

@willibrandon willibrandon marked this pull request as draft September 7, 2024 22:01
@willibrandon willibrandon force-pushed the fix-resource-utilization-health-check branch from af73b29 to ef268bb Compare September 7, 2024 22:27
@willibrandon willibrandon marked this pull request as ready for review September 7, 2024 22:59
@RussKie RussKie added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Sep 9, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Sep 9, 2024
@willibrandon
Copy link
Contributor Author

@RussKie thanks for the feedback; commit with suggestions pushed.

@RussKie
Copy link
Member

RussKie commented Sep 9, 2024

@evgenyfedorov2 @sebastienros

@RussKie RussKie merged commit 39f5d27 into dotnet:main Sep 9, 2024
6 checks passed
@RussKie
Copy link
Member

RussKie commented Sep 9, 2024

Thank you

@willibrandon willibrandon deleted the fix-resource-utilization-health-check branch September 9, 2024 23:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evgenyfedorov2 evgenyfedorov2 evgenyfedorov2 approved these changes

@RussKie RussKie RussKie approved these changes

Assignees

@willibrandon willibrandon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResourceUtilizationHealthCheck only reports CPU _or_ memory issues, not both
3 participants
@willibrandon @RussKie @evgenyfedorov2