Fix test warning in 9.0 #5437
Merged
Fix test warning in 9.0 #5437
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030) See https://github.com/dotnet/extensions/pull/5435/checks?check_run_id=30404388453
dariusclay
approved these changes
Sep 20, 2024
|
@dariusclay / @eerhardt - Looks like htere's another test (from before that PR) that calls it as well: |
|
Looks like that got removed in the 62c74d3#diff-c8046fc49e1b5a2d71a80ae4566b8a4567b68adef5f6b5a8d0f75026341d15ff cc @joperezr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
This is blocking #5435
See https://github.com/dotnet/extensions/pull/5435/checks?check_run_id=30404388453
cc @rwoll
Microsoft Reviewers: Open in CodeFlow