-
Notifications
You must be signed in to change notification settings - Fork 783
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Parser: more binary expressions recovery (#15255)
- Loading branch information
1 parent
0d81a05
commit 3cdf2d2
Showing
11 changed files
with
233 additions
and
91 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
tests/fsharpqa/Source/Conformance/UnitsOfMeasure/Parenthesis/E_IncompleteParens02.fs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module Module | ||
|
||
a + b |
21 changes: 21 additions & 0 deletions
21
tests/service/data/SyntaxTree/Expression/Binary - Plus 01.fs.bsl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
ImplFile | ||
(ParsedImplFileInput | ||
("/root/Expression/Binary - Plus 01.fs", false, QualifiedNameOfFile Module, | ||
[], [], | ||
[SynModuleOrNamespace | ||
([Module], false, NamedModule, | ||
[Expr | ||
(App | ||
(NonAtomic, false, | ||
App | ||
(NonAtomic, true, | ||
LongIdent | ||
(false, | ||
SynLongIdent | ||
([op_Addition], [], [Some (OriginalNotation "+")]), | ||
None, (3,2--3,3)), Ident a, (3,0--3,3)), Ident b, | ||
(3,0--3,5)), (3,0--3,5))], | ||
PreXmlDoc ((1,0), FSharp.Compiler.Xml.XmlDocCollector), [], None, | ||
(1,0--3,5), { LeadingKeyword = Module (1,0--1,6) })], (true, true), | ||
{ ConditionalDirectives = [] | ||
CodeComments = [] }, set [])) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module Module | ||
|
||
a + |
25 changes: 25 additions & 0 deletions
25
tests/service/data/SyntaxTree/Expression/Binary - Plus 02.fs.bsl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
ImplFile | ||
(ParsedImplFileInput | ||
("/root/Expression/Binary - Plus 02.fs", false, QualifiedNameOfFile Module, | ||
[], [], | ||
[SynModuleOrNamespace | ||
([Module], false, NamedModule, | ||
[Expr | ||
(App | ||
(NonAtomic, false, | ||
App | ||
(NonAtomic, true, | ||
LongIdent | ||
(false, | ||
SynLongIdent | ||
([op_Addition], [], [Some (OriginalNotation "+")]), | ||
None, (3,2--3,3)), Ident a, (3,0--3,3)), | ||
ArbitraryAfterError ("declExprInfixPlusMinus", (3,3--3,3)), | ||
(3,0--3,3)), (3,0--3,3))], | ||
PreXmlDoc ((1,0), FSharp.Compiler.Xml.XmlDocCollector), [], None, | ||
(1,0--3,3), { LeadingKeyword = Module (1,0--1,6) })], (true, true), | ||
{ ConditionalDirectives = [] | ||
CodeComments = [] }, set [])) | ||
|
||
(4,0)-(4,0) parse warning Possible incorrect indentation: this token is offside of context started at position (3:1). Try indenting this token further or using standard formatting conventions. | ||
(3,2)-(3,3) parse error Unexpected token '+' or incomplete expression |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module Module | ||
|
||
M(a + ) |
29 changes: 29 additions & 0 deletions
29
tests/service/data/SyntaxTree/Expression/Binary - Plus 03.fs.bsl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
ImplFile | ||
(ParsedImplFileInput | ||
("/root/Expression/Binary - Plus 03.fs", false, QualifiedNameOfFile Module, | ||
[], [], | ||
[SynModuleOrNamespace | ||
([Module], false, NamedModule, | ||
[Expr | ||
(App | ||
(Atomic, false, Ident M, | ||
Paren | ||
(App | ||
(NonAtomic, false, | ||
App | ||
(NonAtomic, true, | ||
LongIdent | ||
(false, | ||
SynLongIdent | ||
([op_Addition], [], [Some (OriginalNotation "+")]), | ||
None, (3,4--3,5)), Ident a, (3,2--3,5)), | ||
ArbitraryAfterError | ||
("declExprInfixPlusMinus", (3,5--3,5)), (3,2--3,5)), | ||
(3,1--3,2), Some (3,6--3,7), (3,1--3,7)), (3,0--3,7)), | ||
(3,0--3,7))], | ||
PreXmlDoc ((1,0), FSharp.Compiler.Xml.XmlDocCollector), [], None, | ||
(1,0--3,7), { LeadingKeyword = Module (1,0--1,6) })], (true, true), | ||
{ ConditionalDirectives = [] | ||
CodeComments = [] }, set [])) | ||
|
||
(3,4)-(3,5) parse error Unexpected token '+' or incomplete expression |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module Module | ||
|
||
a + | ||
|> () |
Oops, something went wrong.