Warn when obj is inferred

docs/diagnostics.md

@@ -32,7 +32,7 @@ Adding or adjusting diagnostics emitted by the compiler is usually straightforwa
 4. Use another search tool or a tool like Find All References / Find Usages to see where it's used in the compiler source code.
 5. Set a breakpoint at the location in source you found. If you debug the compiler with the same steps, it should trigger the breakpoint you set. This verifies that the location you found is the one that emits the error or warning you want to improve.
 
-From here, you can either simply update the error test, or you can use some of the information at the point in the source code you identified to see if there is more information to include in the error message. For example, if the error message doesn't contain information about the identifier the user is using incorrectly, you may be able to include the name of the identifier based on data the compiler has available at that stage of compilation.
+From here, you can either simply update the error text, or you can use some of the information at the point in the source code you identified to see if there is more information to include in the error message. For example, if the error message doesn't contain information about the identifier the user is using incorrectly, you may be able to include the name of the identifier based on data the compiler has available at that stage of compilation.
 
 If you're including data from user code in an error message, it's important to also write a test that verifies the exact error message for a given string of F# code.
 
@@ -55,3 +55,12 @@ Diagnostics must often format types.
 * When displaying multiple types in a comparative way, for example, two types that didn't match, you will want to display the minimal amount of infomation to convey the fact that the two types are different, for example, `NicePrint.minimalStringsOfTwoTypes`.
 
 * When displaying a type, you have the option of displaying the constraints implied by any type variables mentioned in the types, appended as `when ...`. For example, `NicePrint.layoutPrettifiedTypeAndConstraints`.
+
+## Localization
+
+The file `FSComp.txt` contains the canonical listing of diagnostic messages, but there are also `.xlf` localization files for various languages.
+When changing `FSComp.txt`, you can automatically put placeholder entries in all these `.xlf` files by running `dotnet msbuild /t:UpdateXlf FSharp.sln`.
+
+## Enabling a warning or error by default
+
+The file `CompilerDiagnostics.fs` contains the function `IsWarningOrInfoEnabled`, which determines whether a given diagnostic is emitted.

src/Compiler/Checking/TypeRelations.fs

@@ -134,50 +134,55 @@ let rec TypeFeasiblySubsumesType ndeep g amap m ty1 canCoerce ty2 =
 /// Here x gets a generalized type "list<'T>".
 let ChooseTyparSolutionAndRange (g: TcGlobals) amap (tp:Typar) =
     let m = tp.Range
-    let maxTy, m = 
-         let initialTy = 
-             match tp.Kind with 
-             | TyparKind.Type -> g.obj_ty 
+    let (maxTy, isRefined), m =
+         let initialTy =
+             match tp.Kind with
+             | TyparKind.Type -> g.obj_ty
              | TyparKind.Measure -> TType_measure Measure.One
          // Loop through the constraints computing the lub
-         ((initialTy, m), tp.Constraints) ||> List.fold (fun (maxTy, _) tpc -> 
-             let join m x = 
-                 if TypeFeasiblySubsumesType 0 g amap m x CanCoerce maxTy then maxTy
-                 elif TypeFeasiblySubsumesType 0 g amap m maxTy CanCoerce x then x
-                 else errorR(Error(FSComp.SR.typrelCannotResolveImplicitGenericInstantiation((DebugPrint.showType x), (DebugPrint.showType maxTy)), m)); maxTy
-             // Don't continue if an error occurred and we set the value eagerly 
-             if tp.IsSolved then maxTy, m else
-             match tpc with 
+         (((initialTy, false), m), tp.Constraints) ||> List.fold (fun ((maxTy, haveRefined), _) tpc ->
+             let join m x =
+                 if TypeFeasiblySubsumesType 0 g amap m x CanCoerce maxTy then maxTy, haveRefined
+                 elif TypeFeasiblySubsumesType 0 g amap m maxTy CanCoerce x then x, true
+                 else errorR(Error(FSComp.SR.typrelCannotResolveImplicitGenericInstantiation((DebugPrint.showType x), (DebugPrint.showType maxTy)), m)); maxTy, haveRefined
+             // Don't continue if an error occurred and we set the value eagerly
+             if tp.IsSolved then (maxTy, haveRefined), m else
+             match tpc with
              | TyparConstraint.CoercesTo(x, m) -> 
                  join m x, m
              | TyparConstraint.MayResolveMember(_traitInfo, m) -> 
-                 maxTy, m
-             | TyparConstraint.SimpleChoice(_, m) -> 
+                 (maxTy, haveRefined), m
+             | TyparConstraint.SimpleChoice(_, m) ->
                  errorR(Error(FSComp.SR.typrelCannotResolveAmbiguityInPrintf(), m))
-                 maxTy, m
-             | TyparConstraint.SupportsNull m -> 
-                 maxTy, m
-             | TyparConstraint.SupportsComparison m -> 
+                 (maxTy, haveRefined), m
+             | TyparConstraint.SupportsNull m ->
+                 (maxTy, haveRefined), m
+             | TyparConstraint.SupportsComparison m ->
                  join m g.mk_IComparable_ty, m
              | TyparConstraint.SupportsEquality m -> 
-                 maxTy, m
-             | TyparConstraint.IsEnum(_, m) -> 
+                 (maxTy, haveRefined), m
+             | TyparConstraint.IsEnum(_, m) ->
                  errorR(Error(FSComp.SR.typrelCannotResolveAmbiguityInEnum(), m))
-                 maxTy, m
-             | TyparConstraint.IsDelegate(_, _, m) -> 
+                 (maxTy, haveRefined), m
+             | TyparConstraint.IsDelegate(_, _, m) ->
                  errorR(Error(FSComp.SR.typrelCannotResolveAmbiguityInDelegate(), m))
-                 maxTy, m
-             | TyparConstraint.IsNonNullableStruct m -> 
+                 (maxTy, haveRefined), m
+             | TyparConstraint.IsNonNullableStruct m ->
                  join m g.int_ty, m
              | TyparConstraint.IsUnmanaged m ->
                  errorR(Error(FSComp.SR.typrelCannotResolveAmbiguityInUnmanaged(), m))
-                 maxTy, m
-             | TyparConstraint.RequiresDefaultConstructor m -> 
-                 maxTy, m
-             | TyparConstraint.IsReferenceType m -> 
-                 maxTy, m
-             | TyparConstraint.DefaultsTo(_priority, _ty, m) -> 
-                 maxTy, m)
+                 (maxTy, haveRefined), m
+             | TyparConstraint.RequiresDefaultConstructor m ->
+                 (maxTy, haveRefined), m
+             | TyparConstraint.IsReferenceType m ->
+                 (maxTy, haveRefined), m
+             | TyparConstraint.DefaultsTo(_priority, _ty, m) ->
+                 (maxTy, haveRefined), m)
+    match tp.Kind with
+    | TyparKind.Type ->
+        if not isRefined then
+            warning(Error(FSComp.SR.typrelNeverRefinedAwayFromTop(), m))
+    | _ -> ()
     maxTy, m
 
 let ChooseTyparSolution g amap tp = 

src/Compiler/Driver/CompilerDiagnostics.fs

@@ -368,7 +368,7 @@ let GetWarningLevel diagnostic =
 let IsWarningOrInfoEnabled (diagnostic, severity) n level specificWarnOn =
     List.contains n specificWarnOn
     ||
-    // Some specific warnings/informational are never on by default, i.e. unused variable warnings
+    // Some specific warnings/informational are never on by default, e.g. unused variable warnings
     match n with
     | 1182 -> false // chkUnusedValue - off by default
     | 3180 -> false // abImplicitHeapAllocation - off by default
@@ -379,6 +379,7 @@ let IsWarningOrInfoEnabled (diagnostic, severity) n level specificWarnOn =
     | 3389 -> false // tcBuiltInImplicitConversionUsed - off by default
     | 3390 -> false // xmlDocBadlyFormed - off by default
     | 3395 -> false // tcImplicitConversionUsedForMethodArg - off by default
+    | 3525 -> false // typrelNeverRefinedAwayFromTop - off by default
     | _ ->
         (severity = FSharpDiagnosticSeverity.Info)
         || (severity = FSharpDiagnosticSeverity.Warning

src/Compiler/FSComp.txt

@@ -1631,4 +1631,5 @@ reprStateMachineInvalidForm,"The state machine has an unexpected form"
 3522,tcAnonRecdDuplicateFieldId,"The field '%s' appears multiple times in this record expression."
 3523,tcAnonRecdTypeDuplicateFieldId,"The field '%s' appears multiple times in this anonymous record type."
 3524,parsExpectingExpressionInTuple,"Expecting expression"
-3545,tcMissingRequiredMembers,"The following required properties have to be initalized:%s"
+3525,typrelNeverRefinedAwayFromTop,"A type inference variable has been implicitly inferred to have type `obj`. Consider adding explicit type annotations. This warning is off by default and has been explicitly enabled for this project. You may suppress this warning by using #nowarn \"3525\"."
+3545,tcMissingRequiredMembers,"The following required properties have to be initalized:%s"