Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getting source text async #15148

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Make getting source text async #15148

merged 3 commits into from
Apr 27, 2023

Conversation

0101
Copy link
Contributor

@0101 0101 commented Apr 27, 2023

Get rid of .Result, potential source of UI hangs.

#14903 (comment)

@0101 0101 requested a review from a team as a code owner April 27, 2023 12:17
psfinaki
psfinaki approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I guess the baselines should be updated also.

@0101 0101 enabled auto-merge (squash) April 27, 2023 16:46
@0101 0101 merged commit 6d04d4c into dotnet:main Apr 27, 2023
@allisonchou allisonchou mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
release/17.7
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0101 @psfinaki @abonie @vzarytovskii