Better anonymous record error reporting #15598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
reviewed
Jul 19, 2023
…arfgp/fsharp into inaccurate-error-in-anonymous-record
|
@edgarfgp this is awesome - thanks. Yeah I am not a big anon records user so cannot really say if a dev would really expect this fix for the case it's working for currently. And indeed triggering the code fix evaluation for every 0039 is kind of costly where the new diag is a more targeted and appropriate application. That said, I don't mind keeping it for both diags for now until somebody complains about it's speed or uselessness. After all, somebody created it in its current shape so was motivated :D |
psfinaki
approved these changes
Jul 24, 2023
auduchinok
reviewed
Jul 25, 2023
….com/edgarfgp/fsharp into inaccurate-error-in-anonymous-record
auduchinok
suggested changes
Jul 25, 2023
auduchinok
approved these changes
Jul 25, 2023
|
Addressed all the comments. Let me know if there is anything else that I need to cover. ? |
0101
reviewed
Jul 27, 2023
tests/FSharp.Compiler.ComponentTests/Conformance/Types/RecordTypes/AnonymousRecords.fs
Show resolved
Hide resolved
0101
reviewed
Jul 27, 2023
tests/FSharp.Compiler.ComponentTests/Conformance/Types/RecordTypes/AnonymousRecords.fs
Outdated
Show resolved
Hide resolved
….com/edgarfgp/fsharp into inaccurate-error-in-anonymous-record
0101
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14814
Update: A new quick fix can be added based on the new error number