Add trivia information to SynConst.Measure #15614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please also capture ranges of optional things, like |
Yes, I'll add a range to SynMeasure.One. As far as I can see, that's the only one missing. |
|
The interesting use-case for |
- add tests - update baselines
dawedawe
commented
Jul 18, 2023
auduchinok
reviewed
Jul 18, 2023
- add test - update surface baselines
nojaf
reviewed
Jul 18, 2023
- add test and put other tests inside a module - update baselines
- add test - update baselines
… into add_measure_trivia
T-Gro
approved these changes
Jul 19, 2023
auduchinok
reviewed
Jul 19, 2023
|
To me, this seems to be okay now. @auduchinok, how about you? |
auduchinok
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Just one comment from my side, otherwise it seems good to go in. Thanks @dawedawe!
psfinaki
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined work with @nojaf
This adds trivia information to SynConst.Measure to help editor tooling dealing with these.