Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-functional code fix improvements #15729

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Non-functional code fix improvements #15729

merged 2 commits into from
Aug 1, 2023

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Aug 1, 2023

  • Changing option to voption in the internal interface to reduce allocations
  • Using FSharpRangeToTextSpan instead of TryFSharpRangeToTextSpan - this has been inconsistent so far and I cannot see this throwing in the code fix context. If it does throw - it should be tested and fixed on the code fix level
  • Fixing a typo in a file name
  • Splitting some code

@psfinaki psfinaki requested a review from a team as a code owner August 1, 2023 15:43
@psfinaki psfinaki enabled auto-merge (squash) August 1, 2023 17:10
@psfinaki psfinaki merged commit 6dd6899 into dotnet:main Aug 1, 2023
24 checks passed
@psfinaki psfinaki deleted the codefixes-20 branch August 1, 2023 18:06
@allisonchou allisonchou mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0101 0101 0101 approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psfinaki @0101 @abonie