-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analyzer & code fix for ~IDE0047~ FS3583: remove unnecessary parentheses #16079
Commits on Oct 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f7d4b36 - Browse repository at this point
Copy the full SHA f7d4b36View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa17921 - Browse repository at this point
Copy the full SHA aa17921View commit details
Commits on Oct 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8207085 - Browse repository at this point
Copy the full SHA 8207085View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7403f4 - Browse repository at this point
Copy the full SHA f7403f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9113205 - Browse repository at this point
Copy the full SHA 9113205View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7377e41 - Browse repository at this point
Copy the full SHA 7377e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37142b6 - Browse repository at this point
Copy the full SHA 37142b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f51569a - Browse repository at this point
Copy the full SHA f51569aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5aa829 - Browse repository at this point
Copy the full SHA a5aa829View commit details -
Configuration menu - View commit details
-
Copy full SHA for a31049b - Browse repository at this point
Copy the full SHA a31049bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92bcc2f - Browse repository at this point
Copy the full SHA 92bcc2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4528ee - Browse repository at this point
Copy the full SHA c4528eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a176f26 - Browse repository at this point
Copy the full SHA a176f26View commit details
Commits on Oct 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for aa04c18 - Browse repository at this point
Copy the full SHA aa04c18View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4bcdc7 - Browse repository at this point
Copy the full SHA f4bcdc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34f037b - Browse repository at this point
Copy the full SHA 34f037bView commit details
Commits on Oct 8, 2023
-
getTextAtRange → getSourceLineStr
* Use `getSourceLineStr` and enable handling sensitive indentation inside parens.
Configuration menu - View commit details
-
Copy full SHA for 5a6c260 - Browse repository at this point
Copy the full SHA 5a6c260View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a1f313 - Browse repository at this point
Copy the full SHA 9a1f313View commit details -
Configuration menu - View commit details
-
Copy full SHA for dea8ffc - Browse repository at this point
Copy the full SHA dea8ffcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bd1097 - Browse repository at this point
Copy the full SHA 9bd1097View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48d172b - Browse repository at this point
Copy the full SHA 48d172bView commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 919dc4d - Browse repository at this point
Copy the full SHA 919dc4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f71794 - Browse repository at this point
Copy the full SHA 7f71794View commit details -
Configuration menu - View commit details
-
Copy full SHA for 591c5df - Browse repository at this point
Copy the full SHA 591c5dfView commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f06cdd5 - Browse repository at this point
Copy the full SHA f06cdd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e493e1 - Browse repository at this point
Copy the full SHA 8e493e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5059bf2 - Browse repository at this point
Copy the full SHA 5059bf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5c281d - Browse repository at this point
Copy the full SHA e5c281dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb951ab - Browse repository at this point
Copy the full SHA fb951abView commit details -
Configuration menu - View commit details
-
Copy full SHA for a82be7c - Browse repository at this point
Copy the full SHA a82be7cView commit details -
Be (somewhat) more systematic about precedence, &c.
* Represent precedence for more kinds of expression than just symbolic infix operators. * Handle exprs potentially confusable with type applications. * Handle more numeric literal cases.
Configuration menu - View commit details
-
Copy full SHA for 178bdc5 - Browse repository at this point
Copy the full SHA 178bdc5View commit details
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4da7680 - Browse repository at this point
Copy the full SHA 4da7680View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d10c9d - Browse repository at this point
Copy the full SHA 9d10c9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf7c62a - Browse repository at this point
Copy the full SHA bf7c62aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbf91df - Browse repository at this point
Copy the full SHA bbf91dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6decef7 - Browse repository at this point
Copy the full SHA 6decef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbdd095 - Browse repository at this point
Copy the full SHA cbdd095View commit details -
Configuration menu - View commit details
-
Copy full SHA for b30c503 - Browse repository at this point
Copy the full SHA b30c503View commit details
Commits on Oct 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 02edd60 - Browse repository at this point
Copy the full SHA 02edd60View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed7aa1e - Browse repository at this point
Copy the full SHA ed7aa1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19da092 - Browse repository at this point
Copy the full SHA 19da092View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1271c6e - Browse repository at this point
Copy the full SHA 1271c6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e30168b - Browse repository at this point
Copy the full SHA e30168bView commit details -
Move diagnostic creation logic into its own file
* We're still calling the logic directly inside of `DocumentDiagnosticAnalyzer` rather than exporting the type as an implementation of the `IFSharpUnnecessaryParenthesesDiagnosticAnalyzer` interface, since that interface does not exist upstream in Roslyn, and it seems like we would currently prefer not to go through the logistics of upstreaming it.
Configuration menu - View commit details
-
Copy full SHA for a2c9fe2 - Browse repository at this point
Copy the full SHA a2c9fe2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58d08d1 - Browse repository at this point
Copy the full SHA 58d08d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8e44ca - Browse repository at this point
Copy the full SHA a8e44caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a62e22 - Browse repository at this point
Copy the full SHA 5a62e22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2181148 - Browse repository at this point
Copy the full SHA 2181148View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2df60d9 - Browse repository at this point
Copy the full SHA 2df60d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a906b35 - Browse repository at this point
Copy the full SHA a906b35View commit details
Commits on Oct 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e1d8a7b - Browse repository at this point
Copy the full SHA e1d8a7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f542cb - Browse repository at this point
Copy the full SHA 5f542cbView commit details
Commits on Oct 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for caeceb8 - Browse repository at this point
Copy the full SHA caeceb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a62a50 - Browse repository at this point
Copy the full SHA 8a62a50View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc2c0fb - Browse repository at this point
Copy the full SHA cc2c0fbView commit details -
The prefix op rules are tricky…
* +Assorted other bits and bobs
Configuration menu - View commit details
-
Copy full SHA for daf39fa - Browse repository at this point
Copy the full SHA daf39faView commit details
Commits on Oct 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for caccbf9 - Browse repository at this point
Copy the full SHA caccbf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9ec3f1 - Browse repository at this point
Copy the full SHA a9ec3f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1eeaa5d - Browse repository at this point
Copy the full SHA 1eeaa5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b758378 - Browse repository at this point
Copy the full SHA b758378View commit details -
Configuration menu - View commit details
-
Copy full SHA for dec772c - Browse repository at this point
Copy the full SHA dec772cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43605d0 - Browse repository at this point
Copy the full SHA 43605d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2f1666 - Browse repository at this point
Copy the full SHA d2f1666View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4494ccd - Browse repository at this point
Copy the full SHA 4494ccdView commit details
Commits on Oct 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for addc8d6 - Browse repository at this point
Copy the full SHA addc8d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7cca0f - Browse repository at this point
Copy the full SHA a7cca0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c96ec3a - Browse repository at this point
Copy the full SHA c96ec3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dab4696 - Browse repository at this point
Copy the full SHA dab4696View commit details -
Configuration menu - View commit details
-
Copy full SHA for a57de4f - Browse repository at this point
Copy the full SHA a57de4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9958126 - Browse repository at this point
Copy the full SHA 9958126View commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ba48167 - Browse repository at this point
Copy the full SHA ba48167View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73a55b7 - Browse repository at this point
Copy the full SHA 73a55b7View commit details -
Pretty sure we don't actually need that
* Upon further thought, I'm pretty sure we _don't_ need to memoize the checking for dangling right-hand expressions, because we never dive deeper than needed for the check at hand, and the check will be quite shallow unless there are vast amounts of, say, nested matches inside of an if-condition body, but even then, such a check is both necessary and will only happen once, e.g.: ```fsharp let f x = if (match x with | _ -> match x with | _ -> match x with | _ -> match x with | _ -> match x with | _ -> if x then x else x) then x else x ``` If any other if-expression were found, or any nested parenthesized expression, or any construct without an exposed right-hand expression, the dive would end.
Configuration menu - View commit details
-
Copy full SHA for 80067ea - Browse repository at this point
Copy the full SHA 80067eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a7e969f - Browse repository at this point
Copy the full SHA a7e969fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31440be - Browse repository at this point
Copy the full SHA 31440beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3710278 - Browse repository at this point
Copy the full SHA 3710278View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb15dd0 - Browse repository at this point
Copy the full SHA eb15dd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b077e09 - Browse repository at this point
Copy the full SHA b077e09View commit details
Commits on Oct 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1d6db65 - Browse repository at this point
Copy the full SHA 1d6db65View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2b70f9 - Browse repository at this point
Copy the full SHA a2b70f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3800ee2 - Browse repository at this point
Copy the full SHA 3800ee2View commit details
Commits on Oct 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cc04486 - Browse repository at this point
Copy the full SHA cc04486View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfdcab3 - Browse repository at this point
Copy the full SHA dfdcab3View commit details -
* This test purported to test FS1182, but the actual diagnostic that is generated from the example is FS1183.
Configuration menu - View commit details
-
Copy full SHA for 13c2840 - Browse repository at this point
Copy the full SHA 13c2840View commit details -
Configuration menu - View commit details
-
Copy full SHA for 953b580 - Browse repository at this point
Copy the full SHA 953b580View commit details
Commits on Oct 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d49b21e - Browse repository at this point
Copy the full SHA d49b21eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53b80ad - Browse repository at this point
Copy the full SHA 53b80adView commit details -
Configuration menu - View commit details
-
Copy full SHA for e622dd2 - Browse repository at this point
Copy the full SHA e622dd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for deb313f - Browse repository at this point
Copy the full SHA deb313fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b4a347 - Browse repository at this point
Copy the full SHA 7b4a347View commit details -
Configuration menu - View commit details
-
Copy full SHA for 518af84 - Browse repository at this point
Copy the full SHA 518af84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19637f3 - Browse repository at this point
Copy the full SHA 19637f3View commit details
Commits on Oct 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4025df7 - Browse repository at this point
Copy the full SHA 4025df7View commit details