Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: [Linux,macOS] PlatformNotSupportedException on FSI on overflowing content at end of terminal #16251

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Nov 10, 2023

This fixes #14946

Verification attempt #1:
Debugging WSL in VS.
This works except for not starting a terminal. Output is shown in VS output pane, but input cannot be entered, or I have not figured out way how.

Verification attempt #2:

This did repro using regular dotnet fsi within WSL (Ubuntu) from the SDK from me.
I then use the same on a self-built dotnet fsi.dll from my local drive.
After the fix, it did not reproduce on WSL (Ubuntu) anymore.

Proof:

FsiNotFailingWslmp4.mp4

@T-Gro T-Gro requested a review from a team as a code owner November 10, 2023 13:16
@vzarytovskii vzarytovskii merged commit d441308 into dotnet:main Nov 10, 2023
24 checks passed
@T-Gro T-Gro deleted the 14946-dotnet-fsi-broken-on-inputs-that-take-more-than-1-line branch November 10, 2023 17:38
@athrun
Copy link

athrun commented Dec 17, 2023

I can currently reproduce this bug on MacOS 14.0 with Apple Silicon using the latest dotnet 8 version available from Homebrew [1].

It looks like Homebrew is building dotnet 8 from the .NET VMR repo—do we know if this patch has made it there? It looks like the v8.0.0 tag on the VMR is dated Nov 2 while this patch is dated Nov 11.

[1] https://github.com/Homebrew/homebrew-core/blob/52f39075aa291380d1ab59d2da239afac57d0940/Formula/d/dotnet.rb

20231217153917 - 2023 — ~Csa2023 — -fish — ttys006@2x

$ dotnet --info
.NET SDK:
 Version:           8.0.100
 Commit:            57efcf1350
 Workload version:  8.0.100-manifests.2d90560f

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  14.0
 OS Platform: Darwin
 RID:         osx-arm64
 Base Path:   /opt/homebrew/Cellar/dotnet/8.0.0/libexec/sdk/8.0.100/

.NET workloads installed:
 Workload version: 8.0.100-manifests.2d90560f
There are no installed workloads to display.

Host:
  Version:      8.0.0
  Architecture: arm64
  Commit:       5535e31a71

.NET SDKs installed:
  8.0.100 [/opt/homebrew/Cellar/dotnet/8.0.0/libexec/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 8.0.0 [/opt/homebrew/Cellar/dotnet/8.0.0/libexec/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 8.0.0 [/opt/homebrew/Cellar/dotnet/8.0.0/libexec/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/opt/homebrew/Cellar/dotnet/8.0.0/libexec]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Dotnet fsi broken on inputs that take more than 1 line
4 participants