[FS-1140] add Boolean-returning and return-type-directed partial active patterns #16473

ijklam · 2023-12-28T17:29:57Z

Description

Implements this

Current progress:

Checklist

RFC added
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated:
Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

Release notes files:
- If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
- If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
- If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.
Information about the release notes entries format can be found in the documentation.
Example:
- More inlines for Result module. (PR #16106)
- Correctly handle assembly imports with public key token of 0 length. (Issue #16359, PR #16363)
  *while! (Language suggestion #1038, PR #14238)
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

add an option to control visibility of `remarks`

vzarytovskii · 2023-12-28T19:28:28Z

This will need a small RFC, describing the approach and codegen, so we don't lose it, since it's a change to spec.

ijklam · 2023-12-29T15:03:37Z

This will need a small RFC, describing the approach and codegen, so we don't lose it, since it's a change to spec.

RFC added

ijklam · 2023-12-30T02:12:30Z

Now these cases will be not allowed. Maybe it needs some more proper error message?

github-actions · 2023-12-30T14:46:03Z

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description

src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

LanguageFeatures.fsi docs/release-notes/.Language/preview.md

src/Compiler/FSComp.txt

src/Compiler/TypedTree/TypedTree.fs

tests/fsharp/Compiler/Language/StructActivePatternTests.fs

src/Compiler/Checking/NameResolution.fs

src/Compiler/TypedTree/TypedTree.fs

src/Compiler/Checking/PatternMatchCompilation.fs

src/Compiler/Checking/CheckExpressions.fs

tests/fsharp/Compiler/Language/StructActivePatternTests.fs

tests/fsharp/Compiler/Language/BoolPartialActivePatternTests.fs

src/Compiler/TypedTree/TypedTree.fs

ijklam · 2024-01-20T15:33:11Z

Could someone fix the test FSharp.Compiler.UnitTests.AssemblySigning.AssemblyKeyNameAttribute NETCOREAPP? Or tell me how to fix it?

psfinaki · 2024-01-22T10:52:11Z

@Tangent-90 maybe this helps.

vzarytovskii · 2024-01-23T11:39:40Z

Is this still WIP as title suggests, or ready for review?

ijklam · 2024-01-23T11:55:59Z

Is this still WIP as title suggests, or ready for review?

It may need the RFC to be accepted first?

ijklam · 2024-01-23T14:13:23Z

@vzarytovskii Title changed, it's now ready

vzarytovskii · 2024-01-29T13:32:11Z

Now these cases will be not allowed. Maybe it needs some more proper error message?

@Tangent-90 I need a bit more clarity here. You mean it won't be allowed only in case of bool, right? Still going to work for options?

vzarytovskii · 2024-01-29T13:37:42Z

Now these cases will be not allowed. Maybe it needs some more proper error message?

@Tangent-90 I need a bit more clarity here. You mean it won't be allowed only in case of bool, right? Still going to work for options?

Yeah, just tested on your branch, was worried for a moment that it's a breaking change :)

ijklam · 2024-01-29T13:42:47Z

Now these cases will be not allowed. Maybe it needs some more proper error message?

@Tangent-90 I need a bit more clarity here. You mean it won't be allowed only in case of bool, right? Still going to work for options?

The behavior of options and voptions doesn't changed.

baronfel · 2024-02-01T17:02:47Z

@Tangent-90 I just want to say that this is awesome, the idea is awesome, you are awesome, and I can't wait to use this.

tests/FSharp.Compiler.ComponentTests/Conformance/Types/StructTypes/StructActivePatterns.fs

vzarytovskii · 2024-02-02T12:07:11Z

@Tangent-90 thanks a lot for this contribution!

auduchinok · 2024-03-08T18:30:53Z

...er.ComponentTests/Language/BooleanReturningAndReturnTypeDirectedPartialActivePatternTests.fs

+    FSharp """let (|IsA|_|) x = x = "A"
+
+match "A" with 
+| IsA result -> "A" 


Why do we try to resolve result to another symbol here (see the error on line 101)? Lowercase names at argument positions are never being resolved to any other symbol in patterns and always create new local values (or are ignored during recovery).

This is very inconsistent to the rest of the language. It should probably be an error about an extra arg instead, definitely not the 'unresolved name' one.

This is because active pattern returning _ option or _ voption can capture return value by the last argument, but active pattern returning bool doesn't. The test is to check it works.

New error added, see #16846.

ijklam and others added 7 commits December 9, 2023 20:51

make remarks and returns visible in quick info

4d1f7c4

move remarks to the end of summarys

a7f5d23

add an option to control visibility of `remarks`

format code

d6d7a39

fix tests

b940c49

format code

c5612f3

add bool partial active pattern

ec0ae2d

Merge branch 'dotnet:main' into main

ea01b34

ijklam added 2 commits December 29, 2023 23:15

fix cannot pass arguments to bool AP

ad146ce

bool partial AP always be treated as unit option

8d5842b

rename code, add and fix tests

3243208

ijklam and others added 4 commits December 30, 2023 22:51

add tests and release note

47a70d8

Merge branch 'main' into main

f22d382

fix test

337f169

fix test

7241ec1

ijklam marked this pull request as ready for review December 30, 2023 16:34

ijklam requested a review from a team as a code owner December 30, 2023 16:34

brianrourkeboll reviewed Jan 1, 2024

View reviewed changes

rename and fix typo

ab2cff0

T-Gro reviewed Jan 2, 2024

View reviewed changes

tests/fsharp/Compiler/Language/StructActivePatternTests.fs Show resolved Hide resolved

T-Gro reviewed Jan 2, 2024

View reviewed changes

tests/fsharp/Compiler/Language/BoolPartialActivePatternTests.fs Outdated Show resolved Hide resolved

vzarytovskii reviewed Jan 2, 2024

View reviewed changes

src/Compiler/TypedTree/TypedTree.fs Outdated Show resolved Hide resolved

ijklam and others added 5 commits January 2, 2024 21:59

Merge branch 'main' into main

1a264c4

modify ActivePatternReturnKind.IsStruct

5ceb20e

Merge branch 'main' of https://github.com/Tangent-90/fsharp

36a7244

fix build error

53a0d6c

Merge branch 'main' into main

2c15fc3

ijklam added 7 commits January 20, 2024 00:15

update comment

3c58a1a

move tests

17fe616

format code

1859fe0

fix test

2d67527

fix tests

5438fa2

fix tests

f443d87

fix tests

b86dd32

vzarytovskii added 2 commits January 23, 2024 12:39

Merge branch 'main' into main

89c9231

Updated FCS release notes as well

5a882c9

ijklam changed the title ~~[WIP] add bool partial active pattern~~ [FS-1140] add Boolean-returning and return-type-directed partial active patterns Jan 23, 2024

vzarytovskii approved these changes Jan 29, 2024

View reviewed changes

Merge branch 'main' into main

a8c296a

T-Gro approved these changes Feb 1, 2024

View reviewed changes

T-Gro reviewed Feb 1, 2024

View reviewed changes

tests/FSharp.Compiler.ComponentTests/Conformance/Types/StructTypes/StructActivePatterns.fs Outdated Show resolved Hide resolved

ijklam and others added 2 commits February 2, 2024 19:02

Merge branch 'main' into main

ecce3c2

update test

721056c

vzarytovskii merged commit 4390d68 into dotnet:main Feb 2, 2024
28 checks passed

edgarfgp mentioned this pull request Feb 20, 2024

Allow returning bool instead of unit option for partial active patterns fsharp/fslang-suggestions#1041

Closed

5 tasks

auduchinok reviewed Mar 8, 2024

View reviewed changes

ijklam mentioned this pull request Apr 19, 2024

Add error tcActivePatternArgumentCountNotMatch #16846

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FS-1140] add Boolean-returning and return-type-directed partial active patterns #16473

[FS-1140] add Boolean-returning and return-type-directed partial active patterns #16473

ijklam commented Dec 28, 2023 •

edited

Loading

vzarytovskii commented Dec 28, 2023 •

edited

Loading

ijklam commented Dec 29, 2023 •

edited

Loading

ijklam commented Dec 30, 2023

github-actions bot commented Dec 30, 2023 •

edited

Loading

ijklam commented Jan 20, 2024 •

edited

Loading

psfinaki commented Jan 22, 2024

vzarytovskii commented Jan 23, 2024

ijklam commented Jan 23, 2024 •

edited

Loading

ijklam commented Jan 23, 2024

vzarytovskii commented Jan 29, 2024

vzarytovskii commented Jan 29, 2024

ijklam commented Jan 29, 2024 •

edited

Loading

baronfel commented Feb 1, 2024

vzarytovskii commented Feb 2, 2024 •

edited

Loading

auduchinok Mar 8, 2024 •

edited

Loading

ijklam Mar 9, 2024

[FS-1140] add Boolean-returning and return-type-directed partial active patterns #16473

[FS-1140] add Boolean-returning and return-type-directed partial active patterns #16473

Conversation

ijklam commented Dec 28, 2023 • edited Loading

Description

Checklist

vzarytovskii commented Dec 28, 2023 • edited Loading

ijklam commented Dec 29, 2023 • edited Loading

ijklam commented Dec 30, 2023

github-actions bot commented Dec 30, 2023 • edited Loading

❗ Release notes required

ijklam commented Jan 20, 2024 • edited Loading

psfinaki commented Jan 22, 2024

vzarytovskii commented Jan 23, 2024

ijklam commented Jan 23, 2024 • edited Loading

ijklam commented Jan 23, 2024

vzarytovskii commented Jan 29, 2024

vzarytovskii commented Jan 29, 2024

ijklam commented Jan 29, 2024 • edited Loading

baronfel commented Feb 1, 2024

vzarytovskii commented Feb 2, 2024 • edited Loading

auduchinok Mar 8, 2024 • edited Loading

Choose a reason for hiding this comment

ijklam Mar 9, 2024

Choose a reason for hiding this comment

ijklam commented Dec 28, 2023 •

edited

Loading

vzarytovskii commented Dec 28, 2023 •

edited

Loading

ijklam commented Dec 29, 2023 •

edited

Loading

github-actions bot commented Dec 30, 2023 •

edited

Loading

ijklam commented Jan 20, 2024 •

edited

Loading

ijklam commented Jan 23, 2024 •

edited

Loading

ijklam commented Jan 29, 2024 •

edited

Loading

vzarytovskii commented Feb 2, 2024 •

edited

Loading

auduchinok Mar 8, 2024 •

edited

Loading