-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change inline hints naming to inlay hints #17266
Conversation
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
// e.g. signature hints above the line, pipeline hints on the side and so on. | ||
|
||
[<Export(typeof<IFSharpInlineHintsService>)>] | ||
type internal FSharpInlineHintsService [<ImportingConstructor>] (settings: EditorOptions) = | ||
[<Export(typeof<IFSharpInlayHintsService>)>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would imagine this should stay the same, since it's what roslyn uses to import it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out! I don't know what I'm doing (in terms of how this integrates with the tooling), lol, and was just looking for some low-hanging fruit F# tasks to contribute. I created the draft request to see how the CI would yell at me after the first pass.
I'll change these and the others you mentioned back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the minimum working change would be to change the naming in the messages and options. Pretty much everything non-code, and what has "inline" as a string.
@@ -4,24 +4,24 @@ namespace Microsoft.VisualStudio.FSharp.Editor.Hints | |||
|
|||
open System.Collections.Immutable | |||
open System.ComponentModel.Composition | |||
open Microsoft.CodeAnalysis.ExternalAccess.FSharp.InlineHints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay the same, since it's what roslyn exposes
@@ -5,7 +5,7 @@ namespace Microsoft.VisualStudio.FSharp.Editor.Hints | |||
open System.Collections.Immutable | |||
open System.Threading | |||
open Microsoft.CodeAnalysis.Text | |||
open Microsoft.CodeAnalysis.ExternalAccess.FSharp.InlineHints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Description
Fixes # (issue, if applicable)
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: