Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep extra parens around unit & tuples in arg pats #17618

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

brianrourkeboll
Copy link
Contributor

@brianrourkeboll brianrourkeboll commented Aug 27, 2024

Description

Another followup to #16079, et seq.

There are several scenarios where it is impossible to know whether the parentheses are required, or whether they may affect compilation, by looking only at the syntax. I addressed this for invocations in #17012, but not for definitions.

Checklist

  • Test cases added.
  • Release notes entry updated.

* There are several scenarios where it is impossible to know whether the
  parentheses are required, or whethery they may affect compilation, by
  looking only at the syntax.
Copy link
Contributor

github-actions bot commented Aug 27, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@brianrourkeboll brianrourkeboll marked this pull request as ready for review August 27, 2024 18:11
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner August 27, 2024 18:11
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for polishing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants