-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FS-1045] Add FuncConvert.FromFunc, FuncConvert.FromAction APIs #4815
Conversation
I have updated the RFC linked above to cover the updated changes in this PR. E |
@brettfo @KevinRansom Should updates to FSharp.Core target dev15.8 or master? Thanks |
@dsyme I would say master. We're currently flowing all changes from master into dev15.8 (this will be disabled as we try to stabilize 15.8 at the divisional level), but we're not flowing anything from dev15.8 to master. |
Targeting dev15.8 |
Not to say this is a bad approach but I've found this usage of invoke leads me to deadlocks when working with async f# with no obvious alternative. Shouldn't there be async friendly alternatives too? |
…et#4815) * add func overloads * adjust based on C# testing * fix test break * fix test * update surface area * fix test * align inlines * Merge error
Continuation of #3013 (comment)
RFC https://github.com/fsharp/fslang-design/blob/master/RFCs/FS-1045-func-to-fsharpfunc-overloads.md
Addresses #1847 - ToFSharpFunc(Func) missing in .NET Core.
Adds
There was no good way to create an FSharpFunc object from C# on .NET core with a method call.