-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ImplicitZero instead of Return unit #773
Conversation
Perhaps here: tests\fsharp\core\comprehensions\test.fsx ? |
163838d
to
130c86b
Compare
I've added the tests. Comments welcome. |
|
||
module SideEffectListTests = | ||
#if Portable | ||
let printfn s = printfn "%s" s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you copy/paste from near tests (good), but maybe this is good opportunity to cleanup this duplication, adding the printfn
function at top level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enricosada maybe, or better to get rid of the root cause. I mean why isn't it simply working for Portable
too?
I've marked the language suggestion as approved https://fslang.uservoice.com/forums/245727-f-language/suggestions/10999326-interpret-do-action-as-let-action-in-zer |
Thanks for the contribution @mexx !! |
Motivation: fsprojects/FSharp.Control.AsyncSeq#38
UserVoice
This PR don't have any new test, any guidance where to find the tests for CEs and to put new for the change is welcome.