Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adorn fsharp Version.Details.xml dependencies as SourceBuild #10959

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Adorn fsharp Version.Details.xml dependencies as SourceBuild #10959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,11 @@
<Uri>https://github.com/dotnet/fsharp</Uri>
<Sha>f8d54670c81ec6e29d312867207a38d0dc3aa192</Sha>
</Dependency>
<Dependency Name="Microsoft.SourceBuild.Intermediate.fsharp" Version="5.0.2-beta.21321.2" CoherentParentDependency="Microsoft.NET.Sdk">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Microsoft.FSharp.Compiler cannot be adorned as source-build as it's version does not match the SB intemerdiate package version therefore the SB Intermediate dependency must be explicitly added.

<Uri>https://github.com/dotnet/fsharp</Uri>
<Sha>f8d54670c81ec6e29d312867207a38d0dc3aa192</Sha>
<SourceBuild RepoName="fsharp" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.NET.Test.Sdk" Version="17.0.0-preview-20210518-01" CoherentParentDependency="Microsoft.NET.Sdk">
<Uri>https://github.com/microsoft/vstest</Uri>
<Sha>ad32654bc155a059fda263f0ec99b445058d84ea</Sha>
Expand Down