Enable source-link in SourceBuild #14698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on value of DisableSourceLink property
NikolaMilosavljevic
requested review from
crummel,
MichaelSimons and
lbussell
MichaelSimons
approved these changes
Oct 10, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#2883
Follows up on change in dotnet/runtime: dotnet/runtime#76685 which was merged into installer's release/7.0.1xx with #14692
Related changes in Arcade are also in flight, one of them was merged: dotnet/arcade#11153, the other is in PR: dotnet/arcade#11191. Note: changes in Arcade are not needed for this to work e2e, since I'm updating the target override in installer repo (src/SourceBuild/tarball/content/ArcadeOverrides/SourceBuildArcadeBuild.targets).