Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable package version props flow for roslyn-analyzers #15350

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jan 25, 2023

  • Please add description for changes you are making.
  • If there is an issue related to this PR, please add the reference.

@mmitche mmitche requested a review from a team as a code owner January 25, 2023 21:14
@mmitche
Copy link
Member Author

mmitche commented Jan 25, 2023

The required changes have flowed into sdk.

@MichaelSimons
Copy link
Member

The required changes have flowed into sdk.

What changes are those?

What is the impact on https://github.com/dotnet/installer/blob/main/src/SourceBuild/patches/roslyn-analyzers/0001-Eliminate-pre-built-assets-during-source-build-for-r.patch? What parts of that patch should be back ported and what would be obsolete?

@mmitche
Copy link
Member Author

mmitche commented Jan 25, 2023

@mmitche
Copy link
Member Author

mmitche commented Jan 25, 2023

The required changes have flowed into sdk.

What changes are those?

What is the impact on https://github.com/dotnet/installer/blob/main/src/SourceBuild/patches/roslyn-analyzers/0001-Eliminate-pre-built-assets-during-source-build-for-r.patch? What parts of that patch should be back ported and what would be obsolete?

The patch shouldn't have an effect on this. I can work on removing it through.

@mmitche
Copy link
Member Author

mmitche commented Jan 25, 2023

@MichaelSimons I'm not exactly sure how to interpret the pre-built report. I see more mentions of roslyn-analyzers than another build I checked, but they all appear to be ILLink.Tasks.

@MichaelSimons
Copy link
Member

@MichaelSimons I'm not exactly sure how to interpret the pre-built report. I see more mentions of roslyn-analyzers than another build I checked, but they all appear to be ILLink.Tasks.

I looked at the report from the PR validation and everything looks good to me. The only prebuilts in r-a are full fx related because SBRP doesn't include the 1.0.3 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants